Add notifications #1352
Add notifications #1352
Conversation
ghost
added
the
hobinjk
force-pushed
the
rules-alerts
branch
from
365cddb
to
11e7615
Compare
|
It should work! I'm not sure what it does if the to-be-notified device is asleep/unresponsive |
| response.status(200).json({publicKey: vapid.publicKey}); | ||
| }); | ||
|
|
||
| PushController.post('/register', async (request, response) => { |
There was a problem hiding this comment.
General question: Is there a way to deregister?
There was a problem hiding this comment.
If someone revokes the notification permission it will be removed in the sendNotification's error handler
src/models/PushSubscriptions.js
Outdated
| } | ||
| async load() { | ||
| this.subscriptions = await Database.getPushSubscriptions(); | ||
| } |
There was a problem hiding this comment.
Missing a closing } here.
There was a problem hiding this comment.
Woops, meant to delete this file
| */ | ||
| function NotificationEffectBlock(ruleArea, onPresentationChange, onRuleUpdate) { | ||
| RulePartBlock.call(this, ruleArea, onPresentationChange, onRuleUpdate, | ||
| 'Notification', '/optimized-images/rule-icons/notification.svg'); |
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
+ Coverage 75.3% 75.46% +0.16%
==========================================
Files 123 125 +2
Lines 5989 6225 +236
Branches 842 885 +43
==========================================
+ Hits 4510 4698 +188
- Misses 1306 1353 +47
- Partials 173 174 +1
Continue to review full report at Codecov.
|
|
Yeah, the if/while thing is just a drawback of a different part of the rules engine that I can fix in a different PR |
Fixes #1295