Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Lock NPM dependencies for npm install #1286

Merged

Commits on Aug 22, 2018

  1. build: Lock NPM dependencies for npm install

    I observed a regression caused to dependencies updates,
    build is file but you can't use UI to add things
    (browser complains on module.export = App)
    Probably caused by babel update from beta49 to rc2 (TBC).
    
    Project prefers yarn over npm,
    but npm install could be used by developers or scripts.
    
    Note that, Adding a (potentially unaligned) lock file,
    could create ambiguity
    but IMHO it's better to support both than only yarn.
    
    Related links:
    
    https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files
    
    yarnpkg/yarn#5654 (comment)
    
    Change-Id: I9489e365b6d3a70102a7d2ae1e44feb7aeb28c06
    Signed-off-by: Philippe Coval <p.coval@samsung.com>
    rzr committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    11b1a2e View commit details
    Browse the repository at this point in the history