Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Push Settings button needed? #282

Open
williamsba opened this issue Dec 22, 2022 · 2 comments
Open

Is the Push Settings button needed? #282

williamsba opened this issue Dec 22, 2022 · 2 comments
Labels
question Further information is requested

Comments

@williamsba
Copy link
Member

In the WP dashboard visit the Algolia Search > Search Page you'll see the Push Settings button at the top. Clicking this button will re-sync your Algolia configuration settings and reset config items like 'Searchable attributes' to the plugin defaults. This seems very edge case and most likely someone will overwrite their configuration in Algolia without realizing it.

Should we remove it? Maybe create an Advanced Config section? Open to suggestions!

@williamsba williamsba added the question Further information is requested label Dec 22, 2022
@tw2113
Copy link
Member

tw2113 commented Dec 22, 2022

The button doesn't just reset to defaults. With the hooks in the plugin, you can customize all of the settings in the Algolia Dashboard and clicking this button pushes those customized settings to the API and your dashboard. Any settings that aren't included in your code version, would get set back to defaults, but if you have custom values, those values would be retained.

It's really a topic of either ALL controlled via code and sync'd when changed, or all controlled via Algolia Dashboard.

@williamsba
Copy link
Member Author

The decision was made to move this button down to an "advanced config" section. Also need to add a warning when clicked so it's clear what is about to happen and the admin can confirm before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants