Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery still getting enqueued with InstantSearch #257

Open
tw2113 opened this issue Nov 1, 2022 · 4 comments
Open

jQuery still getting enqueued with InstantSearch #257

tw2113 opened this issue Nov 1, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@tw2113
Copy link
Member

tw2113 commented Nov 1, 2022

https://wordpress.org/support/topic/dont-load-jquery-2/

jQuery and jQuery Migrate still show up

Screen Shot 2022-11-01 at 12 35 00 PM

@tw2113 tw2113 added the bug Something isn't working label Nov 1, 2022
@tw2113
Copy link
Member Author

tw2113 commented Nov 1, 2022

Turns out this is because we rely on /wp-includes/js/wp-util.js which has its own dependency on jQuery.

This file provides the wp.template() functions that we use to help with rendering some of the autocomplete and instantsearch information.

@tw2113
Copy link
Member Author

tw2113 commented Nov 21, 2022

This may be going away as an issue once Autocomplete 1.x gets handled, since templating has changed a lot between versions.

@tw2113
Copy link
Member Author

tw2113 commented Apr 26, 2023

This will also be getting able to be forced with InstantSearch 5.x which is removing older legacy templating methods, which we still utilize.

@asharirfan asharirfan added this to the 3.0.0 milestone Sep 29, 2023
@tw2113
Copy link
Member Author

tw2113 commented May 28, 2024

While we're moving on from wp-util template usage in the Instantsearch.php file, we're momentarily leaving the libraries included, as we don't want to break users' websites that have customized the older style. They should be granted time to update/upgrade.

Thus leaving this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants