Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color contrast handling #99

Open
ravewebdev opened this issue Sep 10, 2020 · 2 comments · May be fixed by #100
Open

Improve color contrast handling #99

ravewebdev opened this issue Sep 10, 2020 · 2 comments · May be fixed by #100
Assignees
@ravewebdev
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@ravewebdev
Copy link
Contributor

Expand upon color contrast handling (introduced in #91):
@ravewebdev ravewebdev added this to the 2.1.0 milestone Sep 10, 2020
@ravewebdev ravewebdev self-assigned this Sep 10, 2020
@ravewebdev ravewebdev added the enhancement New feature or request label Sep 10, 2020
@ravewebdev
Copy link
Contributor Author

9/10 EOD Update:

  • Began experimenting with fast-average-color package to determine average color of media elements. Appears to work for images but running into errors with videos.

@ravewebdev ravewebdev linked a pull request Sep 10, 2020 that will close this issue
Draft
3 tasks
@ravewebdev
Copy link
Contributor Author

9/11 EOD Update:

  • Implemented fast-average-color and contrast check for image backgrounds.
  • Continuing to troubleshoot fast-average-color with video backgrounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravewebdev ravewebdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Improve color contrast handling WebDevStudios/wds-blocks
1 participant
@ravewebdev