-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/more updates #6
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good improvements, the comments I made could probably just become new issues to work. @khleomix do we have any kind of plan/roadmap/idea for what this should become?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can make this a dynamic year within this kind of block based template?
<!-- /wp:paragraph --> | ||
</div> | ||
</div> | ||
<!-- wp:cover {"minHeight":360,"customGradient":"linear-gradient(253deg,rgba(6,147,227,1) 0%,rgb(84,121,221) 100%)","isDark":false,"align":"full"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create theme.json level gradients to choose from to make this more consistant and create a css var for easy reuse.
Closes #5
DESCRIPTION
theme.json
to version 2 following https://schemas.wp.org/trunk/theme.json and https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-migrations/SCREENSHOTS
OTHER
STEPS TO VERIFY
How do we test this?
The theme still works, and styles on
theme.json
are now functional.DOCUMENTATION
Will this pull request require updating the theme documentation? Currently on README.md.