Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate base Gravity Form styles #149

Closed
efuller opened this issue Feb 4, 2016 · 4 comments
Closed

Integrate base Gravity Form styles #149

efuller opened this issue Feb 4, 2016 · 4 comments
Assignees

Comments

@efuller
Copy link
Contributor

efuller commented Feb 4, 2016

Working on the feature/gravity-forms branch.

Initial Sass file can be found here.

Right now I'm using some local variables to make styling the forms easier, but after bouncing a few ideas around with @colorful-tones I think it might make sense to create global form variables.

Any thoughts, ideas or suggestions would be appreciated!

Here is an initial list of items for the next designers call:

  • Create/use global form variables
  • Use 'placeholder' selectors for all/most GF field types
@colorful-tones
Copy link
Contributor

Yeah, I think having a _forms.scss partial inside the assets/sass/utilities/variables/ would totally make sense. I would even argue that I would like to see use of both local and global variables in this instance. So the global form variables are things like this in the _forms.scss partial...$form-background: $color-white; and then local variables in _gravity-forms.scss partial, like $gf-form-background: $form-background;

@gregrickaby
Copy link
Contributor

Be sure to check form styles after a successful Ajax submission. This has bitten me in the past...

@colorful-tones
Copy link
Contributor

Barely worth noting, and probably overkill, but we might want to think about overriding GF helper layout classes to use Flexbox if we're going to be ALL OVER the FLEXBOX!

@efuller
Copy link
Contributor Author

efuller commented Feb 12, 2016

Current Todo List:
Feel free to add items if there is anything specific that should be addressed.

  • Create _forms.scss inside utilities/variables to hold global form variables
  • Convert modules/_forms.scss to use new global variables
  • Setup plugins/_gravity-forms.scss with local varaibles
  • Mobile Responsive
  • Style form after successful/unsuccessful Ajax submission
  • Error styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants