Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /bower_components from version control #146

Closed
colorful-tones opened this issue Feb 4, 2016 · 5 comments
Closed

Remove /bower_components from version control #146

colorful-tones opened this issue Feb 4, 2016 · 5 comments
Assignees

Comments

@colorful-tones
Copy link
Contributor

I would recommend we .gitignore bower_components/

@gregrickaby
Copy link
Contributor

Unless you have a build server, you're not supposed to ignore bower_components/.

Unlike node_modules/, bower_components/ was meant to house dependencies that will be served to the end user. http://stackoverflow.com/a/22328067

@colorful-tones
Copy link
Contributor Author

All bower_components are available as NPM packages, and are up-to-date. Wonder if we should drop using Bower, and just streamline tooling to use NPM only?

It would look something like this:
https://github.com/colorful-tones/wd_s/blob/media-query-splitting/package.json#L40
https://github.com/colorful-tones/wd_s/blob/media-query-splitting/Gruntfile.js#L90

@gregrickaby
Copy link
Contributor

We discussed this on the Designers call last week. We voted to keep using Bower because the NPM versions of both Bourbon & Neat are out-of-date.

@colorful-tones
Copy link
Contributor Author

They can't be out of date, and are not out of date, because they're served from the same repo. The only discrepancy may be the author forgot to update the package.json version number when bumping up their project version number.

NPM - Publishing NPM Packages - Updating the Package

@gregrickaby
Copy link
Contributor

Believe me, nobody wants to ditch Bower (and move to NPM) more than I. (Heck, I'm using NPM to enqueue Bourbon/Neat in the Gulp feature branch!)

Let's talk about it again on the next call. Please add it to the agenda, and feel better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants