Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ids #48

Open
MananSinghGulati opened this issue Oct 6, 2021 · 7 comments
Open

ids #48

MananSinghGulati opened this issue Oct 6, 2021 · 7 comments

Comments

@MananSinghGulati
Copy link

Can you add ids to each waifu, so we can somehow use those ids to get a specific waifu? Make it visible in the API link. Example, it says URL:LINK , added another element, id:number

@JSH32
Copy link
Member

JSH32 commented Oct 7, 2021

This is a good addition. I'll add IDs to the images later and you will be able to get the image link by ID

@MananSinghGulati
Copy link
Author

@Riku32 thanks for listening to the suggestion. You can automate the process and generate ids rather than putting them manually

@JSH32
Copy link
Member

JSH32 commented Oct 26, 2021

Yeah planning on it, I'll get to implementing it next weekend. The IDs will be returned with each image and you can get the URL and data about the image by querying the ID. Response will likely be changed to

{
    "id": 48
    "url": "https://i.waifu.pics/image.png",
    "type": "waifu",
    "nsfw": false,
    "uploaded": "2021-10-24 12:47:09"
}

@MananSinghGulati
Copy link
Author

yes, that will be better

@MananSinghGulati
Copy link
Author

Are you guys going to do it?

@JSH32
Copy link
Member

JSH32 commented Apr 14, 2022

Full scale rewrite commencing soon. Rewriting backend in elixir and frontend in react. Expect this to be part of it.

@faridmovsumov
Copy link

This would be a great feature +1. Are there still plans to add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants