Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If one transition calls prepare() before another finishes, which one aborts/fails? #174

Closed
jakearchibald opened this issue Aug 3, 2022 · 4 comments
Labels
open-spec-issue Unaddressed issue in the spec

Comments

@jakearchibald
Copy link
Collaborator

In the current implementation, the new transition will fail.

I think we should abandon the old one in favour of the new one. This better matches most navigations, where if you click one link, then another, the former navigation is abandoned in favour of the latter.

@jakearchibald jakearchibald changed the title If one transition starts before another happens, which one aborts/fails? If one transition starts before another finished, which one aborts/fails? Aug 3, 2022
@jods4
Copy link

jods4 commented Aug 3, 2022

Would be nice if the API supported multiple concurrent animations, that would enable scenarios where it's used to transitions states of sub-parts of the page (like widgets).

E.g. a tab control on a page could use it to animate going from one page to the next, same for a carousel control animating its position.
If both are present on the page, they should be able to animate their contents independently.

@jakearchibald
Copy link
Collaborator Author

@jods4 agreed. This is being discussed in #52.

To clarify, this issue is about two transitions that cannot happen concurrently.

@jakearchibald jakearchibald changed the title If one transition starts before another finished, which one aborts/fails? If one transition calls prepare() before another finishes, which one aborts/fails? Aug 3, 2022
@khushalsagar khushalsagar added the open-spec-issue Unaddressed issue in the spec label Aug 16, 2022
@khushalsagar
Copy link
Collaborator

Closely related to the broader issue for dealing with concurrent transition requests discussed in #175.

@khushalsagar
Copy link
Collaborator

Addressed in tabatkins/specs#97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-spec-issue Unaddressed issue in the spec
Projects
None yet
Development

No branches or pull requests

3 participants