Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS definition errors since 8.5.0 #854

Closed
julientechdev opened this issue May 6, 2024 · 0 comments
Closed

TS definition errors since 8.5.0 #854

julientechdev opened this issue May 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@julientechdev
Copy link

julientechdev commented May 6, 2024

Describe the bug
After updating the lib from 8.4.0 to 8.5.0 (and 8.5.1), we have TS errors on build

To Reproduce
Steps to reproduce the behavior:
Update a project using the lib to 8.5.0 or 8.5.1, with skipLibCheck set to false in tsconfig so that it checks against libs.

Expected behavior
Should build fine like in 8.4.0

Here are the build errors:
` > vue-tsc --noEmit && vite build --emptyOutDir

  ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:372:41 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

  372     selectDate?: (day: { value: Date }, isNext: boolean = false) => {};
                                              ~~~~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:373:68 - error TS2304: Cannot find name 'boolea'.

  373     presetDate?: (value: Date[] | string[] | Date | string, noTz?: boolea) => void;
                                                                         ~~~~~~

  ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:425:51 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

  425         handleMonthYearChange?: (isNext: boolean, fromNav = false) => void;
                                                        ~~~~~~~~~~~~~~~

  ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:432:48 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

  432         updateTime: (value: number | number[], isHours = true, isSeconds = false) => void;
                                                     ~~~~~~~~~~~~~~

  ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:432:64 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

  432         updateTime: (value: number | number[], isHours = true, isSeconds = false) => void;
                                                                     ~~~~~~~~~~~~~~~~~


  Found 5 errors in the same file, starting at: ../../node_modules/.pnpm/@vuepic+vue-datepicker@8.5.1_vue@3.4.26/node_modules/@vuepic/vue-datepicker/index.d.ts:372`

Environment:
macOS 14.4.1
node 20.12.2
pnpm 8.15.8
typescript 5.4.5

@julientechdev julientechdev added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels May 6, 2024
@julientechdev julientechdev changed the title TS definition errors since 7.5.0 TS definition errors since 8.5.0 May 6, 2024
@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants