Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing model version check for Active reduction #4655

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: Fixing model version check for Active reduction #4655

merged 3 commits into from
Oct 17, 2023

Conversation

peterychang
Copy link
Collaborator

No description provided.

@peterychang peterychang changed the title Fixing model version check for Active reduction [fix] Fixing model version check for Active reduction Oct 17, 2023
@peterychang
Copy link
Collaborator Author

Would it be worth adding another check so that the save_load checks if the version is either (9.0 <= version < 9.4) || version >= 9.10?

@peterychang peterychang changed the title [fix] Fixing model version check for Active reduction fix: Fixing model version check for Active reduction Oct 17, 2023
@jackgerrits
Copy link
Member

Hmm yeah true that could work

@peterychang peterychang merged commit 4734d3f into VowpalWabbit:master Oct 17, 2023
115 checks passed
@bassmang bassmang mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

@lokitoth lokitoth Awaiting requested review from lokitoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterychang @jackgerrits