feat: not self consistent speed up #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests modifies the behavior the EMT scorer features when using the not-self-consistent flag.
In particular, the previous implementation included all 2nd-order interactions of memory features. This worked fine on datasets with a small number of features but quickly degraded in performance for datasets with a large feature count due to computational complexity of O(n(n+1)/2). This pull requests modifies this behavior by only interacting features with their matching counterparts. This new operation has computational complexity of O(n).
To test the impact of the change I ran an experiment on 200 openml datasets. The new features only resulted in a 1% increase in loss on average.