-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vcpkg for windows ci #4608
Conversation
@@ -24,38 +24,33 @@ jobs: | |||
env: | |||
CMAKE_BUILD_DIR: ${{ github.workspace }}/vw/build | |||
SOURCE_DIR: ${{ github.workspace }}/vw | |||
VCPKG_ROOT: ${{ github.workspace }}/vcpkg | |||
VCPKG_REF: f14984af3738e69f197bf0e647a8dca12de92996 | |||
VCPKG_ROOT_VW: ${{ github.workspace }}/vw/ext_libs/vcpkg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think VCPKG_ROOT
is read by some of the tooling and used. What is the reason for changing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was getting reset to the wrong value in ilammy/msvc-dev-cmd@v1, I can try to look for another workaround
** approved offline |
No description provided.