Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: No RapidJSON in header files #4219

Merged
merged 11 commits into from
Oct 13, 2022
Merged

refactor: No RapidJSON in header files #4219

merged 11 commits into from
Oct 13, 2022

Conversation

byronxu99
Copy link
Collaborator

Hopefully this is a permanent fix for the GetObject issue

  • Move implementation of functions using RapidJSON to .cc source files
  • Replace the header files with just a declaration of the function
  • Explicitly instantiate templates for the two possible values of <bool audit>
  • Simplify CMake files now that RapidJSON no longer needs to be exported

jackgerrits
jackgerrits approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great! Thank you!

@byronxu99 byronxu99 enabled auto-merge (squash) October 13, 2022 13:26
@byronxu99 byronxu99 merged commit 2522e9e into VowpalWabbit:master Oct 13, 2022
@byronxu99 byronxu99 deleted the rapidjson_explicit_templates branch October 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byronxu99 @jackgerrits