Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup includes #4188

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

jackgerrits
Copy link
Member

Remove redundant includes from headers where possible

@byronxu99
Copy link
Collaborator

Missing reductions_fwd.h?

@jackgerrits
Copy link
Member Author

I removed it in this PR, but it looks like I forgot to remove it from the cmake config

@jackgerrits jackgerrits merged commit 5a57cf4 into VowpalWabbit:master Oct 5, 2022
@jackgerrits jackgerrits deleted the header_cleanup branch October 5, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants