Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test 67 windows failure #4167

Merged
merged 7 commits into from
Sep 27, 2022
Merged

fix: test 67 windows failure #4167

merged 7 commits into from
Sep 27, 2022

Conversation

bassmang
Copy link
Member

@bassmang bassmang commented Sep 27, 2022

resolves #3843

jackgerrits
jackgerrits previously approved these changes Sep 27, 2022
vowpalwabbit/core/src/parse_args.cc Outdated Show resolved Hide resolved
vowpalwabbit/core/src/parse_args.cc Outdated Show resolved Hide resolved
@jackgerrits jackgerrits dismissed their stale review September 27, 2022 18:38

changes to be addressed

@jackgerrits
Copy link
Member

Now that this is fixed, can you unskip the test? #3842

@bassmang bassmang merged commit 4aa60d9 into VowpalWabbit:master Sep 27, 2022
@bassmang bassmang deleted the test67 branch September 27, 2022 20:53
byronxu99 added a commit that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test 67 fails on Windows
2 participants