test: [LAS] calculate num of non-degenerate singular values #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o make some unit tests more precise
olgavrou
commented
Sep 14, 2022
| @@ -133,6 +133,29 @@ void cb_explore_adf_large_action_space<randomized_svd_impl, spanner_impl>::rando | |||
| _impl.run(examples, shrink_factors, U, _S, _V); | |||
| } | |||
|
|
|||
| template <typename randomized_svd_impl, typename spanner_impl> | |||
| size_t cb_explore_adf_large_action_space<randomized_svd_impl, spanner_impl>::number_of_non_degenerate_singular_values() | |||
There was a problem hiding this comment.
this could potentially be used to also return even less actions in the spanner than specified by d
zwd-ms
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use it to make some tests more precise