feat: .NET Core Support #3969
Merged
feat: .NET Core Support #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokitoth
commented
Jun 9, 2022
.vscode/settings.json
Outdated
| @@ -6,5 +6,55 @@ | |||
| ], | |||
cs/CMakeLists.txt.old
Outdated
| @@ -0,0 +1,32 @@ | |||
| message(STATUS "Building .NET Framework Bindings") | |||
cs/unittest/Test1and2.cs
Outdated
| @@ -45,6 +45,9 @@ public void Test1and2() | |||
|
|
|||
| Assert.AreEqual((float)expected, actual, 1e-6, "Learn output differs on line: " + lineNr); | |||
|
|
|||
| ulong vwStr_examplesPerPass = vwStr.PerformanceStatistics.NumberOfExamplesPerPass; | |||
|
Nice! |
rajan-chari
reviewed
Jun 9, 2022
| SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/binaries/") | ||
| endif() | ||
|
|
||
| add_custom_target(launch_vs COMMAND set "BinaryOutputBase=${CMAKE_BINARY_DIR}/binaries" && start "${CMAKE_BINARY_DIR}/vowpal_wabbit.sln") |
rajan-chari
reviewed
Jul 14, 2022
| @@ -31,6 +31,10 @@ public static class ReflectionHelper | |||
| /// <remarks>Can't constraint on Func (or would have to have 11 overloads) nor is it possible to constaint on delegate.</remarks> | |||
| public static System.Delegate CompileToFunc<T>(this Expression<T> sourceExpression) | |||
| { | |||
| #if NETSTANDARD | |||
rajan-chari
reviewed
Jul 14, 2022
cs/unittest/TestAllReduce.cs
Outdated
| @@ -44,6 +44,7 @@ private static void Ingest(VowpalWabbitAsync<CbAdfShared, CbAdfAction> vw, IEnum | |||
|
|
|||
| [TestMethod] | |||
| [TestCategory("Vowpal Wabbit")] | |||
| //[Ignore] | |||
rajan-chari
reviewed
Jul 14, 2022
| @@ -2,20 +2,20 @@ | |||
|
|
|||
rajan-chari
reviewed
Jul 14, 2022
CMakeSettings.json
Outdated
| @@ -2,29 +2,38 @@ | |||
| "configurations": [ | |||
rajan-chari
approved these changes
Jul 14, 2022
|
I'm excited for this :) |
lokitoth
force-pushed
the
dev/DotNetCore
branch
2 times, most recently
from
454435f
to
9516a5f
Compare
…th Asan on Linux.
417 relies on an AutoML test, which is hard-excluded due to lack of dsjson support (411). This makes it invisible when trying to look up dependent inputs on 417. The correct fix is to (1) rewrite the dependency logic and (2) to make dsjson work in C# Unit Tests, but for expediency, do that separately.
lokitoth
force-pushed
the
dev/DotNetCore
branch
from
9516a5f
to
f7c42a2
Compare
also: Fix clang-format to properly exclude only C++/CLI files
…abbit into dev/DotNetCore
|
When will this get released? :) |
|
@PeterDraex probably first couple weeks of September |
Hi, is there any update on the expected release date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch for .NET Core Support
Needs: