Skip to content

Commit

Permalink
Move ALSR change to CI Workflow file
Browse files Browse the repository at this point in the history
It makes more sense to not (potentially) change the developers alsr entropy setting to make the test run through. This should be an active choice even if the test then might fail locally for them.

closes official-stockfish#5182

No functional change
  • Loading branch information
Disservin authored and vondele committed Apr 21, 2024
1 parent 1a8de45 commit 56a9cc5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/sanitizers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ jobs:
- name: Check git
run: git --version

# Since Linux Kernel 6.5 we are getting false positives from the ci,
# lower the ALSR entropy to disable ALSR, which works as a temporary workaround.
# https://github.com/google/sanitizers/issues/1716
# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2056762

- name: Lower ALSR entropy
run: sudo sysctl -w vm.mmap_rnd_bits=28

# Sanitizers

- name: ${{ matrix.sanitizers.name }}
Expand Down
7 changes: 0 additions & 7 deletions tests/instrumented.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@ error()
}
trap 'error ${LINENO}' ERR

# Since Linux Kernel 6.5 we are getting false positives from the ci,
# lower the ALSR entropy to disable ALSR, which works as a temporary workaround.
# https://github.com/google/sanitizers/issues/1716
# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2056762
sudo sysctl -w vm.mmap_rnd_bits=28


# define suitable post and prefixes for testing options
case $1 in
--valgrind)
Expand Down

0 comments on commit 56a9cc5

Please sign in to comment.