Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table attributes does not render #10

Open
gabeLon opened this issue Nov 7, 2019 · 1 comment
Open

Table attributes does not render #10

gabeLon opened this issue Nov 7, 2019 · 1 comment

Comments

@gabeLon
Copy link

gabeLon commented Nov 7, 2019

Hi, @Vitaliy-1 we are also seeing that although our XML tables are formatted with some attributes (e.g. align), these are not considered once the XML is rendered.
Attached you will find an XML sample which renders this way http://www.evidencia.org.ar/index.php/Evidencia/article/view/4232
4232-Texto del artículo-1709-3-10-20191030 (1).xml.zip
Is it possible to add/correct this functionality?

We are using OJS 3.1.2.0 and OldGregg theme.

Best regards

@Vitaliy-1
Copy link
Owner

Hi @gabeLon,

I think it's not a problem to add the support for the align attribute (td and th elements).

We are using OJS 3.1.2.0 and OldGregg theme

Just want to notify that in the next release the Old Gregg theme will be restyled and rewritten (except article landing page); an example of the new design.:

oldGregg_index

so, if any custom changes are done, they'll need to be adapted to the new code.

Also, JATS Parser will be decoupled from the theme; this change, in line with JATS Parser Plugin modification, will allow showing the article's full text on the landing page not only with this theme but other themes as well. JATS Parser Plugin will be responsible for displaying JATS XML either on the galley or article landing page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants