Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dark mode if user has set it as preferred #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use dark mode if user has set it as preferred #341

wants to merge 1 commit into from

Conversation

paazmaya
Copy link
Contributor

Some views force white background, and those that are black, are just too black... Hence a draft PR.

@paazmaya paazmaya force-pushed the prefer-dark-mode-if-user branch 2 times, most recently from 4919ef2 to b6ef74d Compare September 19, 2023 11:29
@paazmaya paazmaya marked this pull request as ready for review September 19, 2023 11:31
@paazmaya
Copy link
Contributor Author

How do the non-color changes look like @pashidlos ?

The color changes shall be finetuned further. My idea here is to have softer look on both light and dark modes, as they are very often with too high contrast and making older, more sensitive eyes to cry…

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.6% 23.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@paazmaya @pashidlos
Separate screens to each test case
d55caf4 
Use dark mode if user has set it as preferred
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

23.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@pashidlos
Copy link
Member

@paazmaya could you check images?
https://visual-regression-tracker.com/8b610e09-8997-40e2-968b-46483090b6c9?buildId=65eb0481-be91-47c1-b04b-2a021b02e6f3

is it possible to retain default colours for light schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashidlos pashidlos Awaiting requested review from pashidlos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paazmaya @pashidlos