Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 2 support #8

Closed
lordazzi opened this issue Sep 19, 2017 · 6 comments
Closed

Angular 2 support #8

lordazzi opened this issue Sep 19, 2017 · 6 comments
Assignees

Comments

@lordazzi
Copy link

What about convert the JavaScript in project to TypeScript? For Angular 2 support?

@Sami-Radi
Copy link
Collaborator

Hello,

We plan on releasing a Ionic 3 test bench in the near future using the plugin and add a complete type definition file for it's TypeScript implementation.

For now, you can use the plugin within Ionic 3.0 but you will need to write your own type definition file.

Best regards,

@lordazzi
Copy link
Author

Nice!

@lordazzi
Copy link
Author

lordazzi commented Oct 2, 2017

I have created the definition files for your lib and made the pull request for DefinitelyTyped.
You can see the pull request here:
DefinitelyTyped/DefinitelyTyped#20061 (comment)

And you can download de definition files here:
https://www.npmjs.com/package/@types/cordova-plugin-canvascamera

@Sami-Radi
Copy link
Collaborator

Hello,

I've added some remarks about the type definition file on the related thread. I'll update our README.md with your type definition repository as soon as it is validated by the DefinitelyTyped team.

Thanks for your contribution. 👍

Best Regards,

@lordazzi
Copy link
Author

lordazzi commented Oct 4, 2017

Nice, I'll work in that

@Sami-Radi
Copy link
Collaborator

Hello,

I've updated our README.md with your type definition repository.

Thanks for contributing.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants