Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #6

Open
terezasoukupova opened this issue Feb 22, 2017 · 5 comments
Open

Bugfix #6

terezasoukupova opened this issue Feb 22, 2017 · 5 comments

Comments

@terezasoukupova
Copy link

Hello,
I think I have found a bug in your code. In pymot.py, line 238, where is the overlap computed? I think that there should be something like this before this line:
rect_groundtruth = Rect(groundtruths[gt_index])
rect_hypothesis = Rect(hypotheses[hypo_index])
overlap = rect_groundtruth.overlap(rect_hypothesis)

Am I right?

@DenisKuplyakov
Copy link
Contributor

I also think it looks like a bug. But it's better to solve it this way, without intersecting rects another time:

self.total_overlap_ += 1.0 / munkres_matrix[gt_index][hypo_index]

Still surprised, that results I've get were looking adequate.

@herr-biber
Copy link
Contributor

You are right. Thanks. Looks like a bug. I'd really appreciate a pull request and a small test example which reproduces the bug.

@terezasoukupova
Copy link
Author

terezasoukupova commented Mar 3, 2017

I am sorry, I am new to github and I do not know for what is exactly pull request useful. But another point, isn't it weird, that MOTA can be negative? E.g. when you have no misses, no mismatches and many false positives.

@herr-biber
Copy link
Contributor

See https://help.github.com/articles/creating-a-pull-request/ on how to create a pull request. Basically you fork this repo. Commit changes to your fork and file the pull request to allow me to merge changes made in your fork to be merged into this master.

Negative MOTA is possible, yes.

@DenisKuplyakov
Copy link
Contributor

DenisKuplyakov commented May 3, 2017

@terezasoukupova has created pull request for this: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants