Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarantine artifact is broken when using wss for comms #3523

Closed
scudette opened this issue May 30, 2024 · 3 comments
Closed

Quarantine artifact is broken when using wss for comms #3523

scudette opened this issue May 30, 2024 · 3 comments
Milestone

Comments

@scudette
Copy link
Contributor

The Windows.Remediation.Quarantine artifact assumes http or https urls and does not figure out the correct server check url to verify server connectivity

We need to update the artifact to work with wss

@predictiple
Copy link
Contributor

The issue seems perhaps broader than just that one artifact. The http_client plugin can be used directly in an artifact, like with Windows.Remediation.Quarantine, or indirectly as with the upload parameter type or inventory_get().

#3345 tries to solve the issue for inventory_get() by substituting 'wss' with 'https' but maybe this subtitution should happen in http_client itself?

@scudette scudette added this to the 0.73 Release milestone Aug 27, 2024
@scudette
Copy link
Contributor Author

http_client() does not support the wss protocol anyway.

@scudette
Copy link
Contributor Author

Fixed by #3741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants