Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table doesn't work #53

Closed
Basdl76 opened this issue Sep 2, 2019 · 3 comments
Closed

Add table doesn't work #53

Basdl76 opened this issue Sep 2, 2019 · 3 comments
Assignees
Projects

Comments

@Basdl76
Copy link

Basdl76 commented Sep 2, 2019

Adding/creating table doesn't work
When i select table and click on create table nothing happened. Also no console error.
Hope you can fix it :))

version: "van-ons/laraberg": "^1.0",

image

image

@Elidrake
Copy link

The problem seems to be that, for whatever reason, the Create Table button has the type set to button rather than submit, and the Table form is looking for that submit event.

@kapitoxapux
Copy link

The problem seems to be that, for whatever reason, the Create Table button has the type set to button rather than submit, and the Table form is looking for that submit event.

Changing type="button" to type="submit" fixed that

@mauricewijnia mauricewijnia self-assigned this Sep 30, 2019
@mauricewijnia mauricewijnia added this to To do in Laraberg via automation Sep 30, 2019
@mauricewijnia mauricewijnia moved this from To do to In progress in Laraberg Sep 30, 2019
@mauricewijnia
Copy link
Member

This is indeed because the button type is 'button'.
The problem is that Gutenberg leaves a lot of button types empty, this causes a lot of buttons to submit the form that Laraberg is in because the default button type is 'submit'.

I'll be looking into this today, hopefully I can come up with a fix that gets around this issue and any similar issues entirely, if not I'll add this button to the 'whitelist' of submit buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Laraberg
  
Done
Development

No branches or pull requests

4 participants