-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified pip and conda environment; pypi deployment #181
base: main
Are you sure you want to change the base?
Conversation
@matthew-w-lundy @deividribeiro - could you have a look why the vegas workflow is failing? I am not sure I understand the different step of docker generation and pip installation. Maybe it is a small thing only - having this PR included would really by nice! |
Appears to be how in the docker image we are pip installing. Locally running the instructions work in a clean conda environment. I will see if I can modify the test to reasonably still pass with changes to the install. |
@matthew-w-lundy - any progress on this issue? Being able to merge this PR would really be nice, as it simplifies installation. |
Taking a look at this again today to try and resolve |
29f0691
to
578ec0d
Compare
forcing an update to setuptools before pip install
and force a redo of the runtime tests
This pull requests simplifies installation and usage of V2DL3 significantly.
A simple
pip install v2dl3
should do all and then we call the three scripts as command line tools:v2dl3-vegas
v2dl3-generate-index-file
v2dl3-eventdisplay
It is very nice that we can use the same installation for eventdisplay and vegas flavours (at this point only for pip; could do this like also in future for the conda environments).
Replaces also setup.py by the more modern pyproject.toml approach.
Other changes: