Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Camera X/Y coordinates #203

Open
steob92 opened this issue Jan 8, 2024 · 0 comments
Open

Event Camera X/Y coordinates #203

steob92 opened this issue Jan 8, 2024 · 0 comments
Labels
enhancement New feature or request VEGAS Specific to the VEGAS branch

Comments

@steob92
Copy link
Contributor

steob92 commented Jan 8, 2024

I notice we're using "Xoff/Yoff"

evt_dict["Xoff"] = DL3EventTree["Xoff"][mask]
evt_dict["Yoff"] = DL3EventTree["Yoff"][mask]

For EVENTS GADF suggests the optional columns:

DETX type: float, unit: deg

        Reconstructed field of view X (see [Field of view](https://gamma-astro-data-formats.readthedocs.io/en/v0.3/general/coordinates.html#coords-fov)).

DETY type: float, unit: deg

        Reconstructed field of view Y (see [Field of view](https://gamma-astro-data-formats.readthedocs.io/en/v0.3/general/coordinates.html#coords-fov)).

I think this is what we're calling Xoff/Yoff?

For gammapy-background-analysis the camera X/Y is required when mimicing and scrambling data.

I've changed this in the 4f1159e. I think I caught everywhere on the ED side.

I don't see the camera X/Y stored in the vegas side of things. Is this something that can be easily implemented for vegas?

@steob92 steob92 added enhancement New feature or request VEGAS Specific to the VEGAS branch labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request VEGAS Specific to the VEGAS branch
Projects
None yet
Development

No branches or pull requests

1 participant