-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f1159e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steob92 - this is correct, thanks.
Note that it is called
DETX, DETY
and notXDET
,YDET
.The question is if the naming is important enough to merit a complete reprocessing of all files (DL3 step), or if you can add a fix into the background model generator. I agree that it should be correct for all future processing.
Could you also check the FOValign is set correctly in the header, as outlined in the GADF doc?
Please open a PR.
4f1159e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GernotMaier I don't think we need to rerun, for the moment I'll add a
try
block to checkXoff
vsDETX
vs whatever VEGAS' standard is.I'm not 100% sure if my understanding is correct. In ED there is
X/Yoff
andX/Yoff_derot
.Here we use
X/Yoff
which is the "Gamma Point-Of-Origin, in camera coodinates (coodinates -> coordinates link to typo) in (deg)"While
X/Yoff_derot
is "Derotated Gamma Point-Of-Origin (deg, RA/Dec)".So
X/Yoff
would refer toFOVALIGN=ALTAZ
andX/Yoff_derot
would refer toFOVALIGN=RADEC
.Does this sound correct to you?
Perhaps explicitly using
X/Yoff_derot
would remove any ambiguity?I'll open an issue under gammapy-tools (slowly migrating to public) to check the coordinates.