FIXES full screen leaderboard out of order when webhook returns new data #757
Conversation
…ffect hooks in the ScuntLeaderboard component. Previously, sorting was redundantly applied in individual child components
|
ECE444? |
There was a problem hiding this comment.
Looks good! Solid job on identifying where to sort the array in the frontend to ensure that the correct state gets passed down. However, the implementation that I think would have been more optimized is what I implemented here a5fe4cd. This way the array gets sorted at the backend level meaning that it is the most optimized since it is run as database query. Meaning that there is no need for "time consuming" computations in the frontend that can slow down the website load times (in this case its just a sort but you get the idea).
Sorry that the issue was still marked as open while we had fixed it in hot fixes committed to the production branch 😬I still need to consolidate the code together a bit. But I guess it also provides a chance to take a look at the solution we ended up implementing. And just for full transparency, here fe85b34 I still sorted the array in the frontend for some reason lol.
This commit centralizes the leaderboard sorting logic within the useEffect hooks in the ScuntLeaderboard component. Previously, sorting was redundantly applied in individual child components.
Contribution:
Changes include:
-Prop Passing: Updated the ScuntLeaderboardShow component to correctly pass down the sorted leaderboard data to its child components.
These updates enhance the maintainability and consistency of the leaderboard's order across the application.
Issue:
When leaderboard full screen, teams are ordered based on points but as soon as the leaderboard data gets updated via webhook, the order is no longer retained
Closes #571
Accomplishments:
Consistency Across Components: By centralizing the sorting logic, we've ensured that all components reflect a consistent order of the leaderboard data.
Reduced Redundancy: Eliminated redundant sorting in child components, thereby simplifying the codebase and enhancing maintainability.
Resolved Issue #571: Addressed the main concern of the leaderboard order getting disrupted upon receiving new data, ensuring a seamless and consistent user experience.