Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client code bug in page "Create a secure client and server" #1287

Closed
CursedOctopus opened this issue Jun 20, 2024 · 1 comment · Fixed by #1316
Closed

Client code bug in page "Create a secure client and server" #1287

CursedOctopus opened this issue Jun 20, 2024 · 1 comment · Fixed by #1316
Assignees
Labels
Needs developer input Needs input from the development team to resolve type:bug Bug Report

Comments

@CursedOctopus
Copy link

Describe the bug:
The code of "Create a secure client" is wrong.

Steps to reproduce the behavior:
Original:

void Start ()
{
    var settings = new NetworkSettings();
    settings.WithSecureServerParameters(
        serverName: SecureParameters.ServerCommonName,     
        caCertificate: SecureParameters.MyGameClientCA);
    m_Driver = NetworkDriver.Create(settings);

    // ...
}

Expected behavior:
Fixed:

void Start ()
{
    var settings = new NetworkSettings();
    settings.WithSecureClientParameters(
        serverName: SecureParameters.ServerCommonName,     
        caCertificate: SecureParameters.MyGameClientCA);
    m_Driver = NetworkDriver.Create(settings);

    // ...
}

Screenshots
None

Desktop/Tablet/Smartphone (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional info:
None

@CursedOctopus CursedOctopus added the type:bug Bug Report label Jun 20, 2024
@jabbacakes jabbacakes added the Needs developer input Needs input from the development team to resolve label Jul 25, 2024
@jabbacakes jabbacakes self-assigned this Jul 30, 2024
@jabbacakes jabbacakes mentioned this issue Jul 31, 2024
3 tasks
@jabbacakes jabbacakes linked a pull request Jul 31, 2024 that will close this issue
3 tasks
@jabbacakes
Copy link
Collaborator

This code example has been updated in the linked PR, thanks for raising the issue! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs developer input Needs input from the development team to resolve type:bug Bug Report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants