Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear: Start NetworkManager in Awake can have "undesirable results" #1277

Closed
CodeSmile-0000011110110111 opened this issue Jun 9, 2024 · 1 comment · Fixed by #1316
Closed
Assignees
Labels
Needs developer input Needs input from the development team to resolve type:bug Bug Report

Comments

@CodeSmile-0000011110110111
Copy link
Contributor

The DANGER box under NetworkManager here is missing information:

DANGER
Don't start a NetworkManager within a NetworkBehaviour's Awake method as this can lead to undesirable results depending upon your project's settings!

First: "undesirable results" sounds pretty harmless. This should at least hint at the possible issues.

Then it should also indicate what project settings might affect this. Are these NGO specific settings, or script execution order, or something else?

@CodeSmile-0000011110110111 CodeSmile-0000011110110111 changed the title Start NetworkManager in Awake can have "undesirable results" Unclear: Start NetworkManager in Awake can have "undesirable results" Jun 9, 2024
@jabbacakes jabbacakes added the Needs developer input Needs input from the development team to resolve label Jul 25, 2024
@jabbacakes jabbacakes mentioned this issue Jul 31, 2024
3 tasks
@jabbacakes jabbacakes linked a pull request Jul 31, 2024 that will close this issue
3 tasks
@jabbacakes jabbacakes self-assigned this Jul 31, 2024
@jabbacakes
Copy link
Collaborator

We've added more detail about starting NetworkManagers in the linked PR. I'm gonna close this issue as complete now, but feel free to reopen it/leave more comments if you still want more information.

Thanks for raising the issue and engaging with improving the docs, we really appreciate it ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs developer input Needs input from the development team to resolve type:bug Bug Report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants