Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnGainedOwnership and OnLostOwnership #1255

Closed
kevincastejon opened this issue Apr 13, 2024 · 1 comment
Closed

OnGainedOwnership and OnLostOwnership #1255

kevincastejon opened this issue Apr 13, 2024 · 1 comment
Assignees
Labels
docs-request Request for new documentation Needs developer input Needs input from the development team to resolve type:feature New feature or request

Comments

@kevincastejon
Copy link

What documentation page is missing?
The page is not missing but the description of these two methods are unclear and wrong.

(optional) Provide us with more details

- OnGainedOwnership
The current documentation description says that the method is called when the local client gained ownership, but is actually called server-side when any client gain ownership, even remote ones.

- OnLostOwnership
The current documentation description says that the method is called when "we loose ownership", which is unclear and inconsistent with the above method description, but is actually called server-side when any client lost ownership, even remote ones.

@jabbacakes
Copy link
Collaborator

This has been fixed in the two linked PRs. The changes won't be visible in the public API docs until the next release of the package, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-request Request for new documentation Needs developer input Needs input from the development team to resolve type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants