Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Cython IF, DEF #1277

Merged
merged 15 commits into from
Oct 27, 2023
Merged

Remove deprecated Cython IF, DEF #1277

merged 15 commits into from
Oct 27, 2023

Commits on Sep 27, 2023

  1. Add compatibility shims for optional/missing functions 

    This helps remove lots of the deprecated Cython IF/DEF statements
    @ZedThree
    ZedThree committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ce8babc View commit details
    Browse the repository at this point in the history

  2. Invert conditionals for compile-time features, bail early

    @ZedThree
    ZedThree committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    816935a View commit details
    Browse the repository at this point in the history

  3. Add shims for parallel functions

    @ZedThree
    ZedThree committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f64ee26 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Remove unneeded API checking in setup.py

    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4a39d7d View commit details
    Browse the repository at this point in the history

  2. Simplify checking for parallel support a little 

    We only need to know if we have any parallel support at compile time,
and not whether it's netcdf4 or pnetcdf flavour
    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f1e697b View commit details
    Browse the repository at this point in the history

  3. Enable mpi-compat.h to always be included

    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b0a030f View commit details
    Browse the repository at this point in the history

  4. Move compile-time conditional import of parallel modules to code-gen 

    To avoid the last deprecated compile-time `IF`, we instead separate
the two branches of the conditional into different files and choose
which one to include at build time.
    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2578063 View commit details
    Browse the repository at this point in the history

  5. Fix names of feature macros

    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c2dd8cf View commit details
    Browse the repository at this point in the history

  6. Fix missing include of netcdf_par.h

    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f9e7d11 View commit details
    Browse the repository at this point in the history

  7. Move parallel support imports to .pxi so shims get correct type 

    We also need to explicitly cast the comm/info arguments to the correct type
    @ZedThree
    ZedThree committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a83f81b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Fix conditional include of filter header for >=v4.7.0

    @ZedThree
    ZedThree committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    3a8bd68 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'master' into remove-deprecated-def-if 

    * master:
  include fix to pyproject.toml for 3.12
  fix missing part of previous commit
  fix for pkg_resources missing on 3.12
  version 1.6.5 release
  remove 'oversubscribe' option from mpirun
  fix typo
  add python 3.12, remove python 3.7
    @ZedThree
    ZedThree committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d9b810f View commit details
    Browse the repository at this point in the history

  2. Bump version to 1.7.0

    @ZedThree
    ZedThree committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2cde1c4 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry for Cython DEF/IF fixes

    @ZedThree
    ZedThree committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    800d9c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Don't write constants.pyx 

    No longer needed
    @ZedThree
    ZedThree committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0614299 View commit details
    Browse the repository at this point in the history