Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Have nc-autotools use source distribution instead of repository #2601

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented Jan 30, 2023

Instead of a clone of the repository, have the nc-autotools job work from a source distribution prepared by a previous autotools CI job.

This should catch most of the "files not included in EXTRA_DIST" or similar issues I remember, and probably most of the "netcdf-c does not pass make distcheck" errors.

I'm not sure whether this is in scope for a CI job, but the nc-autotools jobs should be a fairly complete copy of make distcheck now; the only things I can think of not included in that job would be make install and make installcheck. I'm only aware of #2431 raising issues with installed files, so that may be less relevant.

Instead of a clone of the repository, have the nc-autotools job work from a source distribution prepared by a previous autotools CI job.

This should catch most of the "files not included in EXTRA_DIST" or similar issues I remember, and probably most of the "netcdf-c does not pass make distcheck" errors.
@DWesl DWesl changed the title CI: Have nc-autotools use source distribution (#1) CI: Have nc-autotools use source distribution instead of repository Jan 31, 2023
@WardF
Copy link
Member

WardF commented Jan 31, 2023

Interesting. There is definitely value here, and no obvious downside other than 18 months down the line "Why are we doing it this way?". It might introduce a little bit of overhead to the already lengthy CI scripts, but as you point out, it would catch extra dist related errors.

I know that the CI triggers can be far more complex than the ones we're using right now; it's entirely possible that we would want this to run as part of the 'one-off' set of tests, and not for every test permutation.

Thanks a lot for this, let me think about how to best integrate it!

@WardF WardF added this to the 4.9.1 milestone Jan 31, 2023
@WardF WardF self-assigned this Jan 31, 2023
@WardF WardF modified the milestones: 4.9.1, 4.9.2 Feb 13, 2023
@WardF WardF modified the milestones: 4.9.2, 4.9.3 May 16, 2023
@WardF WardF merged commit fa8d831 into Unidata:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants