moved hdf5 specific header stuff to hdf5internal.h #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #856.
In this PR I create new include file hdf5internal.h. It contains HDF5-specific stuff from nc4internal.h.
This is part of the separation of the libsrc4 data model from the hdf5 dispatch layer. hdf5internal.h is required by all code in libhdf5, but not in libsrc4.
The separation is not yet complete, and hdf5internal.h is still needed in two places in libsrc4. But when #856 is complete these includes will be removed and hdf5internal.h will only be used in libhdf5, and all of the code in libsrc4 will be independent of hdf5.h.