Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anst/improvements #387

Merged
merged 14 commits into from
Feb 1, 2023
Merged

Anst/improvements #387

merged 14 commits into from
Feb 1, 2023

Conversation

achimmihca
Copy link
Collaborator

What does this PR do?

Last fixes before creating a new release.

  • fix AccordionItomControl fold/expand animation (e.g. in help dialogs)
  • set project version to 0.9.0
  • example theme with static background image
    • used a picture from pixabay
  • make helpIcon not clickable
  • fix song editor side bar width if scrollbar is visible
  • use material icons instead of "<" and ">" characters on ItemPicker
  • fix screen resolution item picker
  • fix implementation to apply focus and hover styles of themes
  • fix player profile images on Android
    • normalization of relative paths was wrong on Unix systems

Dev tools

  • when building Android App Bundle for Google Play then include all CPU architectures

Closes Issue(s)

close #353 (don't know why the issue was closed already, it was still broken)

@achimmihca
remove code line to test internalStorageRoot
42b6df5
@achimmihca
fix AccordionItemControl fold/exapand animation, must use size in pix…
b88bc31 
…els (not "auto" value)
@achimmihca
generated constants
5fd54e9
@achimmihca
set project version to 0.9.0
67e3a1a
@achimmihca
build Android App Bundle (*.aab file) for all CPU architectures
757ad87
@achimmihca
example theme with static background
6b7c4e8
@achimmihca
fix load static background image with relative path
54c6ecb 
- better implementation for disabled themes
@achimmihca
menu item to build signed app bundle without running it
8b559f7
@achimmihca
make help icon not clickable
dacf7c5
@achimmihca
fix song editor left side bar small width if scrollbar is visible
29823cd
@achimmihca
use icons on ItemPicker
3800422
@achimmihca
fix ScreenResolutionItemPickerControl
4e54499 
- there have been duplicate resolutions, such that indexOf was not changing to the next item
@achimmihca
fix apply focus and hover style of themes
911a995 
- did not work when button was focused already when calling the method
- focus style was removed although on pointer exit, although the button was still hovered
@achimmihca
fix player profile images on Android not working
12c9007 
- normalization of relative path was not working, because of unexpected root folder slash
@achimmihca achimmihca merged commit 84df7f1 into master Feb 1, 2023
@achimmihca achimmihca deleted the anst/improvements branch February 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolution to a higher value not possible
1 participant
@achimmihca