fix BuildInfoGenerator: wrong version number and missing commit hash #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command line interface
… C# API returns an older value
|
WTF, the tests were running fine few minutes ago in my fork... |
|
IDK, let's if the executable build works |
It worked! Didn't expected that to be honest 🤣 |
|
nice one! |
|
Good work 💪🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unity's API returns a wrong value when using
ProjectSettings.bundleVersion.The value is now fetched directly from
ProjectSettings.assetfile, which contains the correct value.Git has some issue such that it does not return the commit hash when running the GitHub Actions build.
The value is now fetched from file
.git/refs/heads/masterwithout using any Git commands.Besides this, it also adds
workflow_dispatchto the GitHub Actions config to start them manually.Closes Issue(s)
close #289
Additional Notes