Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gatk4.2 #64

Merged
merged 23 commits into from
Apr 22, 2022
Merged

Feature/gatk4.2 #64

merged 23 commits into from
Apr 22, 2022

Conversation

melferink
Copy link
Member

  • Includes Modules for GATK 4.2.1.0
  • Including gzip option for output VCF files

lvanoijen
lvanoijen requested changes Apr 5, 2022
View reviewed changes
Copy link

@lvanoijen lvanoijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small typo in SelectVariants.nf it is looking ok.
There is also an improvement you can make looking at the coding guidelines (wiki):
-Clear code: Avoid lines longer than 127 characters. -> split long lines in the output and script sections

GATK/4.2.1.0/SelectVariants.nf Outdated Show resolved Hide resolved
lvanoijen
lvanoijen approved these changes Apr 22, 2022
View reviewed changes
Copy link

@lvanoijen lvanoijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@melferink melferink requested a review from sawibo April 22, 2022 11:16
@melferink melferink merged commit 8f3f4e6 into develop Apr 22, 2022
@melferink melferink deleted the feature/gatk4.2 branch April 22, 2022 11:40
@melferink melferink mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawibo sawibo sawibo approved these changes

@lvanoijen lvanoijen lvanoijen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@melferink @sawibo @lvanoijen @rernst @ellendejong