Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TSError diagnosticText non-enumerable to prevent it from logging below stack trace #1632

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Make TSError diagnosticText non-enumerable to prevent it from logging below stack trace #1632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9790ef2
Make tserror diagnosticText non-enumerable to prevent it from logging…
cspotcode Feb 7, 2022
836d783
lint-fix
cspotcode Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,15 @@ export const DEFAULTS: RegisterOptions = {
*/
export class TSError extends BaseError {
name = 'TSError';
diagnosticText!: string;

constructor(public diagnosticText: string, public diagnosticCodes: number[]) {
constructor(diagnosticText: string, public diagnosticCodes: number[]) {
super(`⨯ Unable to compile TypeScript:\n${diagnosticText}`);
Object.defineProperty(this, 'diagnosticText', {
configurable: true,
writable: true,
value: diagnosticText,
});
}

/**
Expand Down