Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[TT-7086] Add hostNetwork option in helm chart #532

Closed
rdcwaldrop1 opened this issue Nov 15, 2022 · 5 comments · Fixed by #537
Closed

[TT-7086] Add hostNetwork option in helm chart #532

rdcwaldrop1 opened this issue Nov 15, 2022 · 5 comments · Fixed by #537
Labels
enhancement New feature or request

Comments

@rdcwaldrop1
Copy link

rdcwaldrop1 commented Nov 15, 2022

Expected Behavior

Given our current ENI Configuration in Amazon EKS we need to run the Tyk Operator deployment with hostNetwork mode set to true. I'd like to be able to specify this as a boolean toggle in the values file.

Potential BDD Test Coverage

Feature: hostNetwork Mode
  As a developer
  I want to enable hostNetwork mode for the deployment
  So that I can install Tyk Operator in my EKS cluster

  Scenario: hostNetwork mode enabled
    Given that .Values.hostNetwork = true
    When I deploy Tyk Operator
    Then the associated pods run with hostNetwork mode enabled

Current Behavior

The current helm chart provides no means to update the hostNetwork value so I am unable to configure this without editing the underlying template. I'd like to bring this chart in as a helm dependency and not have to edit the template.

Possible Solution

A small block could be added here to set hostNetwork mode equal to .Values.hostNetwork mode or a default of false

      hostNetwork:  {{ .Values.hostNetwork | default false }}

Additional Context

@rdcwaldrop1 rdcwaldrop1 added the enhancement New feature or request label Nov 15, 2022
@MichaelTyk MichaelTyk changed the title Add hostNetwork option in helm chart [TT-7086] Add hostNetwork option in helm chart Nov 15, 2022
@komalsukhani
Copy link
Collaborator

Thank you for raising this issue @rdcwaldrop1! I will add this ticket in our backlog and keep you posted about it's progress.

We also welcome community PRs in case you are interested!

@rdcwaldrop1
Copy link
Author

Thank you for raising this issue @rdcwaldrop1! I will add this ticket in our backlog and keep you posted about it's progress.

We also welcome community PRs in case you are interested!

Great! Thanks @komalsukhani. I'd be happy to take a crack at a PR to add this.

@rdcwaldrop1
Copy link
Author

I've added a draft PR with my thinking on the change to enable hostNetwork mode. The PR template asks to describe testing, but I'm not seeing any automated tests in the repo for helm. Typically how is testing for helm changes handled in this repo? Is there a better place to ask this question?

@buraksekili
Copy link
Member

@rdcwaldrop1 you are right, we do not have any testing for helm changes for tyk-operator yet. You can create your PR and once your PR is approved, we can test your PR internally and then merge it.

@rdcwaldrop1
Copy link
Author

Thanks @buraksekili for your feedback here and on the PR. I'll take a look at the process you explained and update the PR accordingly. 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants