New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed building on MacOS Monterey 12.3 #1567

Merged

daniellockyer merged 1 commit into master from fix-m1-build

Apr 12, 2022

Member

daniellockyer commented Apr 12, 2022

refs https://github.com/nodejs/node-gyp/blob/f5fa6b86fd2847ca8c1996102f43d44f98780c4a/lib/find-python.js
refs #1552

Monterey 12.3 removed Python 2, so node-sqlite3 doesn't build because
the v3 binary is called python3 and therefore python is missing
node-gyp has logic to find the python binary and stores it in the PYTHON
env variable
we should be able to switch to using that


          Fixed building on MacOS Monterey 12.3

649c150

refs https://github.com/nodejs/node-gyp/blob/f5fa6b86fd2847ca8c1996102f43d44f98780c4a/lib/find-python.js
refs #1552

- Monterey 12.3 removed Python 2, so `node-sqlite3` doesn't build because
  the v3 binary is called `python3` and therefore `python` is missing
- `node-gyp` has logic to find the python binary and stores it in the `PYTHON`
  env variable
- we should be able to switch to using that

daniellockyer self-assigned this

daniellockyer marked this pull request as ready for review

April 12, 2022 16:08

daniellockyer merged commit d9e7d8b into master

daniellockyer deleted the fix-m1-build branch

April 12, 2022 16:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet