Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support docker to build binary package #1112

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Jan 27, 2019

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: #418
Forwarded: #1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval p.coval@samsung.com

rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Jan 27, 2019
This can be then declined for several arch

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr rzr mentioned this pull request Jan 27, 2019
Copy link
Collaborator

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is sound, some nitpicks.
I think the .dockerignore could probably be a lot more lightweight?

.dockerignore Outdated
# Build artifacts
/build
node_modules/
static/js/lib/stm_web.min.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is this required?

.dockerignore Outdated
# Run-time artifacts
.node-persist/
config/local.js
static/uploads
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with some of these artifacts?

@kewde
Copy link
Collaborator

kewde commented Jan 27, 2019

@rzr Thank you for the contributions.
Technically the PR is alright, it just seems to have some things in it that aren't necessary?
Could you trim it a bit? I look forward to adding CI support.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@rzr rzr force-pushed the sandbox/rzr/review/master branch from cb805d1 to b59ad31 Compare January 28, 2019 09:52
rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Jan 28, 2019
This can be then declined for several arch

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Jan 28, 2019
Just shared as demo May be changed

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Usage:
```
docker build .
```
This can be then declined for several arch, elsewhere.

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr rzr force-pushed the sandbox/rzr/review/master branch from b59ad31 to 4d19c57 Compare January 29, 2019 14:51
@kewde kewde closed this Feb 1, 2019
@kewde kewde reopened this Feb 1, 2019
@kewde kewde merged commit 081aebb into TryGhost:master Feb 4, 2019
@kewde
Copy link
Collaborator

kewde commented Feb 4, 2019

Thank you @rzr

@tkurki
Copy link

tkurki commented Feb 23, 2019

Now that this is merged what's the next step? How do you use this? My ultimate goal is #418.

rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Sep 30, 2019
Just shared as demo May be changed

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Jul 1, 2020
Just shared as demo May be changed

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to CrossStream/node-sqlite3 that referenced this pull request Jul 1, 2020
Just shared as demo May be changed

Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: TryGhost#418
Forwarded: TryGhost#1112
TryGhost#1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants