-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Support docker to build binary package #1112
Conversation
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is sound, some nitpicks.
I think the .dockerignore could probably be a lot more lightweight?
.dockerignore
Outdated
# Build artifacts | ||
/build | ||
node_modules/ | ||
static/js/lib/stm_web.min.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is this required?
.dockerignore
Outdated
# Run-time artifacts | ||
.node-persist/ | ||
config/local.js | ||
static/uploads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with some of these artifacts?
@rzr Thank you for the contributions. |
cb805d1
to
b59ad31
Compare
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Usage: ``` docker build . ``` This can be then declined for several arch, elsewhere. Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
b59ad31
to
4d19c57
Compare
Thank you @rzr |
Now that this is merged what's the next step? How do you use this? My ultimate goal is #418. |
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: #418
Forwarded: #1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval p.coval@samsung.com