Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #809

Closed
ORESoftware opened this issue Apr 19, 2017 · 5 comments
Closed

TypeScript support #809

ORESoftware opened this issue Apr 19, 2017 · 5 comments
Labels

Comments

@ORESoftware
Copy link

ORESoftware commented Apr 19, 2017

Not sure if you have TS support or if that's in the works, but Webstorm complains a lot with this library, saying methods are not recognized or arguments/signatures are wrong. e.g.:

sql.Database => Unresolved type "Database" (WS assumes this is a class/constructor)
db.configure => Unresolved function or method
db.serialize(function(){}); => Argument type Function is not assignable to parameter type Request

screenshot 2017-04-19 14 31 37

It would be really cool if you rewrote with TS (doesn't take that long, usually), and exported some type info.

Here is a really weird warning, by the way:

screenshot 2017-04-19 14 33 41

Thanks!

@natesilva
Copy link

There’s an @types/sqlite3 but it only describes version 2.2. Would be nice to have it updated for version 3.

@hn3000
Copy link

hn3000 commented Jun 8, 2017

An update for version 3.1 has been merged some days ago: DefinitelyTyped/DefinitelyTyped#16656

@kewde
Copy link
Collaborator

kewde commented Apr 15, 2022

@daniellockyer
Copy link
Member

@kewde I believe they also opened a PR for that here: #1527

Will get around to checking it at some point 🙂

@daniellockyer
Copy link
Member

I've merged a PR to add this: ffda15f

I'll be updating the types before releasing soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants