Skip to content

Commit

Permalink
Fixed building on MacOS Monterey 12.3
Browse files Browse the repository at this point in the history
refs https://github.com/nodejs/node-gyp/blob/f5fa6b86fd2847ca8c1996102f43d44f98780c4a/lib/find-python.js
refs #1552

- Monterey 12.3 removed Python 2, so `node-sqlite3` doesn't build because
  the v3 binary is called `python3` and therefore `python` is missing
- `node-gyp` has logic to find the python binary and stores it in the `PYTHON`
  env variable
- we should be able to switch to using that
  • Loading branch information
daniellockyer committed Apr 12, 2022
1 parent 859b95b commit 649c150
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/sqlite3.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/sqlite-autoconf-<@(sqlite_version)/sqlite3.c'
],
'action': ['<!(node -p "process.env.npm_config_python || \\"python\\"")','./extract.py','./sqlite-autoconf-<@(sqlite_version).tar.gz','<(SHARED_INTERMEDIATE_DIR)']
'action': ['<!(node -p "process.env.PYTHON")','./extract.py','./sqlite-autoconf-<@(sqlite_version).tar.gz','<(SHARED_INTERMEDIATE_DIR)']
}
],
'direct_dependent_settings': {
Expand Down

0 comments on commit 649c150

Please sign in to comment.