This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🏃 improve navigation responsiveness with loading substates #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
loading-substates
branch
from
d37ae59
to
d847311
Compare
kevinansfield
changed the title
|
Looks like I have some tests to update here, I'll re-visit those in the morning. |
acburdine
reviewed
Jan 17, 2017
| @@ -3,6 +3,7 @@ import {htmlSafe} from 'ember-string'; | |||
| import injectService from 'ember-service/inject'; | |||
| import run from 'ember-runloop'; | |||
| import {isEmberArray} from 'ember-array/utils'; | |||
| import $ from 'jquery'; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
The test errors here are actually showing a change in behaviour with how version mismatch errors are handled. Previously:
With loading substates:
Thinking about this a bit more I'm not sure this is too much of an issue - it will only occur when a user is navigating in which case any unsaved data is gone anyway. A version mismatch error whilst saving will remain on the same page as no transition is kicked off. VersionMismatch errors should also be an extreme edge case. I'll update the tests to reflect the new behaviour. |
no issue
- add loading substates for all routes that previously blocked transitions until their model had finished loading
- enables immediate response on navigation click
- loading templates include the title bar to provide immediate indication of which page is loading
- loading templates include a new `{{gh-loading-spinner}}` component that will only show the spinner after 200ms to avoid flashing a spinner for users on fast connections
- updated Version Mismatch tests to match new behaviour of intermediate transitions when navigating
kevinansfield
force-pushed
the
loading-substates
branch
from
d847311
to
527ce40
Compare
|
@acburdine updated, should be good to go now 😄 |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
{{gh-loading-spinner}}component that will only show the spinner after 200ms to avoid flashing a spinner for users on fast connections