Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoder streams do not work in flowing mode in Node 10+ #16

Closed
Rantanen opened this issue Dec 9, 2018 · 1 comment
Closed

Decoder streams do not work in flowing mode in Node 10+ #16

Rantanen opened this issue Dec 9, 2018 · 1 comment

Comments

@Rantanen
Copy link

Rantanen commented Dec 9, 2018

Mostly this is for information.

The underlying issue is a Node.js issue (nodejs/node#24915), but since node-ogg seems to be one of the few libraries that combines the highWaterMark: 0 with asynchronous push(), it doesn't seem to be widely encountered.

I mean.. it's apparently been broken for 2 Node releases... :)

One possible workaround for node-ogg would be to use highWaterMark: 1 for the DecoderStream. On the other hand, I'm expecting the issue to be fixed in Node at some point anyway.
@Rantanen Rantanen mentioned this issue Dec 9, 2018
Closed
@TooTallNate
Copy link
Owner

Thanks for the explanation. Looks like this was fixed in Node (nodejs/node@37a5e01), so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TooTallNate @Rantanen