Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsaacLabWrapper reset method bug #181

Open
shubhs0007 opened this issue Aug 2, 2024 · 2 comments
Open

IsaacLabWrapper reset method bug #181

shubhs0007 opened this issue Aug 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@shubhs0007
Copy link

shubhs0007 commented Aug 2, 2024

Description

info variable is undefined if self._reset_once is False

return self._obs_dict["policy"], info

Resulting in the following error -

UnboundLocalError: local variable 'info' referenced before assignment

What skrl version are you using?

1.2.0

What ML framework/library version are you using?

torch 2.2.2+cu118

Additional system information

Python 3.10.14, Ubuntu

@shubhs0007 shubhs0007 added the bug Something isn't working label Aug 2, 2024
@bekleyis95
Copy link

I created an MR for this issue in here.

@Toni-SM
Copy link
Owner

Toni-SM commented Aug 4, 2024

Hi @shubhs0007 and @bekleyis95

Solved in the toni/update_wrappers branch with also include some test for it.

self._obs_dict, reward, terminated, truncated, self._info = self._env.step(actions)

self._obs_dict, self._info = self._env.reset()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants