Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to wrap Isaac Gym Preview 4 Environments if No Wrapper Type is Given #170

Closed
ErcBunny opened this issue Jul 14, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@ErcBunny
Copy link

Description

When running the getting started tutorial:

import isaacgymenvs

# import the environment wrapper
from skrl.envs.wrappers.torch import wrap_env

# create/load the environment using the easy-to-use API from NVIDIA
env = isaacgymenvs.make(seed=0,
                        task="Cartpole",
                        num_envs=512,
                        sim_device="cuda:0",
                        rl_device="cuda:0",
                        graphics_device_id=0,
                        headless=False)

# wrap the environment
env = wrap_env(env)  # or 'env = wrap_env(env, wrapper="isaacgym-preview4")'

env = wrap_env(env) does not work by default.

What skrl version are you using?

1.2.0

What ML framework/library version are you using?

PyTorch (2.3.1+cu121)

Additional system information

Python 3.8.19 on Linux

@ErcBunny ErcBunny added the bug Something isn't working label Jul 14, 2024
@Toni-SM
Copy link
Owner

Toni-SM commented Aug 5, 2024

Hi @ErcBunny

Fixed in branch toni/update_wrappers to be merged in develop soon

elif _in("tasks..*.VecTask", base_classes):
return "isaacgym-preview4" # preview 4 is the same as 3

@Toni-SM
Copy link
Owner

Toni-SM commented Sep 15, 2024

@Toni-SM Toni-SM closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants