Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL parsing broken for certain foreign characters #1039

Closed
JeffreyCA opened this issue Feb 20, 2022 · 0 comments · Fixed by #1254
Closed

URL parsing broken for certain foreign characters #1039

JeffreyCA opened this issue Feb 20, 2022 · 0 comments · Fixed by #1254

Comments

@JeffreyCA
Copy link

Describe the bug

There was a regression introduced between 14.8.26 and 14.8.37 where initializing a Player by URL fetches the wrong URL if it contains special characters.

To Reproduce
Check the browser console to see the URL it tries to load.

Expected - 14.8.26 (Codepen):

import * as Tone from "https://cdn.skypack.dev/tone@14.8.26";
const players = new Tone.Players(
      {
        a: '允.mp3'
      },
      () => {
      }
);

https://cdpn.io/JeffreyCA/fullpage/%E5%85%81.mp3

Broken - 14.8.37 (Codepen):

import * as Tone from "https://cdn.skypack.dev/tone@14.8.37";
const players = new Tone.Players(
      {
        a: '允.mp3'
      },
      () => {
      }
);

https://cdpn.io/JeffreyCA/fullpage/%25E5%2585%2581.mp3

Additional context

Related: #971, #902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant